Legal comments in CSS are removed when empty legal comments are present

[adamwathan]

Given this input:

.example {
  --some-var: var(--tw-empty, /*!*/ /*!*/);
}

/*! I_need_this_comment */

body {
  background-color: red;
}

esbuild produces this output when running esbuild ... --legal-comments=inline:

.example {
  --some-var: var(--tw-empty, );
}

body {
  background-color: red;
}

Removing the /*!*/ /*!*/ nonsense is probably fine (we have to do it in Tailwind to preserve the whitespace between them in some overly aggressive minifiers), but I would at least expect the /!* I_need_this_comment */ comment to be preserved.

If you remove the this line, the comment is preserved as expected:

  .example {
-   --some-var: var(--tw-empty, /*!*/ /*!*/);
  }
  
  /*! I_need_this_comment */
  
  body {
    background-color: red;
  }

Related: tailwindlabs/tailwindcss#6182

Thanks!

[adamwathan]

Legend 🙏

[frederikhors]

@evanw I saw that in the CHANGELOG there are some breaking for the next version. Can I ask you to release this as a fix so any libraries that have ~ in version can be upgraded? Thanks!

[frederikhors]

@evanw can you please release a patch?