Fixed new Buffer() deprecation due to security and usability issues #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @patrickhulce, could you please review this PR and tag a new version? |
patrickhulce
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
thanks @promatik!
FWIW though I wouldn't use this library in electron, sharp+electron-rebuild or the Canvas API would both be much better options
|
I'm using jimp, and they are using this library. |
zed-0xff
pushed a commit
to zed-0xff/jpeg-js
that referenced
this pull request
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the new Deprecation Warning on Chromium 83 (used by Electron 9).
DeprecationWarning: Buffer() is deprecated due to security and usability issuesTested it locally on my project, everything worked as expected.