Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RFC 8226 for ComponentPresentConstraint #100

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Update to RFC 8226 for ComponentPresentConstraint #100

merged 1 commit into from
Nov 8, 2019

Conversation

russhousley
Copy link
Contributor

Use the recently added ComponentPresentConstraint() instead of the previous approach.

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files          89       89           
  Lines        5766     5766           
=======================================
  Hits         5729     5729           
  Misses         37       37
Impacted Files Coverage Δ
pyasn1_modules/rfc8226.py 98.03% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99e2ec...649acb1. Read the comment docs.

@etingof etingof merged commit 883def9 into etingof:master Nov 8, 2019
@etingof
Copy link
Owner

etingof commented Nov 8, 2019

Thank you!

BTW, we can now try the new PermittedAlphabetConstraint feature - master branch temporarily depends on master pyasn1.

@russhousley
Copy link
Contributor Author

Ilya, rfc5708.py does make use of it.

@etingof
Copy link
Owner

etingof commented Nov 8, 2019

Ilya, rfc5708.py does make use of it.

Then the test for it should have failed prior to my latest commit to master where I make pyasn1-modules dependent on pyasn1 master...

@russhousley
Copy link
Contributor Author

Sorry typo. I meant rfc7508.py.

I included a note about updating the requirements.txt when you accept the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants