Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy experience list API should support filtering for country code #3300

Closed
eastandwestwind opened this issue May 13, 2023 · 3 comments
Closed

Comments

@eastandwestwind
Copy link
Contributor

eastandwestwind commented May 13, 2023

Currently the privacy_experience_list endpoint does not support filtering when we only pass in country into the region param (e.g. region=eu). This is because the PrivacyNoticeRegion enum always includes country + region.

We'll need to ensure that we can filter by just country code in a way that guarantees we only retrieve 1 matching experience for the given country + component + display mechanism.

Originally posted by @eastandwestwind in #3191 (comment)

@eastandwestwind eastandwestwind changed the title Privacy experience list should support filtering for country code Privacy experience list API should support filtering for country code May 13, 2023
@pattisdr
Copy link
Contributor

PrivacyExperienceBase.get_related_privacy_notices would need to be updated here - an update to the SQLAlchemy query.

More product input needed here though:

We'll need to ensure that we can filter by just country code in a way that guarantees we only retrieve 1 matching experience for the given country + component + display mechanism.

@mfbrown
Copy link

mfbrown commented Jun 6, 2023

Plan for Sprint 13

@pattisdr
Copy link
Contributor

OK closing in favor of #3611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants