Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mounting fides-js components into a specified HTML container #3293

Closed
allisonking opened this issue May 12, 2023 · 2 comments · Fixed by #3397
Closed

Allow mounting fides-js components into a specified HTML container #3293

allisonking opened this issue May 12, 2023 · 2 comments · Fixed by #3397
Assignees

Comments

@allisonking
Copy link
Contributor

Is your feature request related to a specific problem?

#3191 introduces mounting a Preact component into a site's document.body. This may or may not be ideal in terms of manipulating a site's DOM.

Describe the solution you'd like

As we develop more, we should see how this plays out, and also give the option for a user to specify a "container node selector" which fides-js loads all of its components into. That selector can default to document.body for now, but should be able to be overwritten

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Original discussion: #3191 (comment)

@NevilleS
Copy link
Contributor

Ran into this when doing E2E testing so had to pull it in

@Roger-Ethyca
Copy link
Contributor

moving to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants