refactor: enable withdraw all stake endpoint #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
ghost
changed the title
istae
reviewed
Dec 16, 2022
mrekucci
reviewed
Dec 16, 2022
| return | ||
| } | ||
| logger.Debug("delete stake failed", "error", err) | ||
| logger.Error(nil, "withdraw stake failed") |
There was a problem hiding this comment.
The log message should be the same as the debug message.
|
|
||
| func (c *contract) withdrawFromStake(ctx context.Context, stakedAmount *big.Int) (*types.Receipt, error) { | ||
| var overlayAddr [32]byte | ||
| copy(overlayAddr[:], c.overlay.Bytes()) |
There was a problem hiding this comment.
I think the abi packing needs a [32]byte and not a byte slice
There was a problem hiding this comment.
nope, it needs byte slice, just checked
istae
reviewed
Dec 16, 2022
|
|
||
| func (c *contract) withdrawFromStake(ctx context.Context, stakedAmount *big.Int) (*types.Receipt, error) { | ||
| var overlayAddr [32]byte | ||
| copy(overlayAddr[:], c.overlay.Bytes()) |
There was a problem hiding this comment.
I think the abi packing needs a [32]byte and not a byte slice
notanatol
reviewed
Dec 16, 2022
| @@ -1056,6 +1056,23 @@ paths: | |||
| $ref: "SwarmCommon.yaml#/components/responses/500" | |||
| default: | |||
| description: Default response | |||
| delete: | |||
| summary: Withdraw all staked amount. | |||
| description: Be aware, this endpoint creates an on-chain transactions and transfers BZZ from the node's Ethereum account and hence directly manipulates the wallet balance. | |||
There was a problem hiding this comment.
minor: we can either drop the an or use transaction (singular)
notanatol
reviewed
Dec 16, 2022
|
|
||
| txHash, err := s.stakingContract.WithdrawAllStake(r.Context()) | ||
| if err != nil { | ||
| if errors.Is(err, staking.ErrInsufficientStake) { |
There was a problem hiding this comment.
just wondering: if we withdraw the entire amount of the stake, can we gen the insufficient stake error?
There was a problem hiding this comment.
nope, this edge case deals with the fact that we did not have any stake to begin with
mrekucci
approved these changes
Dec 16, 2022
added 8 commits
December 16, 2022 21:17
istae
approved these changes
Dec 16, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Adds an endpoint to delete all existing stake.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
This change is