Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use withinRadiusFn for the tests #3629

Merged
merged 2 commits into from Dec 7, 2022
Merged

fix: use withinRadiusFn for the tests #3629

merged 2 commits into from Dec 7, 2022

Conversation

aloknerurkar
Copy link
Contributor

@aloknerurkar aloknerurkar commented Dec 7, 2022 •
edited by acud

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

This test failure was seen on master as two changes were merged together and unit tests were not run after rebasing.

This change is Reviewable

@aloknerurkar aloknerurkar merged commit 23572c4 into master Dec 7, 2022
@aloknerurkar aloknerurkar deleted the fixtest branch December 7, 2022 12:59
@aloknerurkar aloknerurkar added this to the 1.10.0 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janos janos janos approved these changes

@mrekucci mrekucci mrekucci approved these changes

@istae istae istae approved these changes

Assignees
No one assigned
Labels
pull-request
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aloknerurkar @janos @mrekucci @istae