Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent reserve put for out of depth chunks #3627

Merged
merged 1 commit into from Dec 7, 2022

Conversation

aloknerurkar
Copy link
Contributor

@aloknerurkar aloknerurkar commented Dec 6, 2022

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

In ModePutSync, if we get a chunk with radius lesser than the last known eviction radius of the batch, we force it to cache and not add it to reserve.


This change is Reviewable

@aloknerurkar aloknerurkar merged commit cbe84cc into master Dec 7, 2022
@aloknerurkar aloknerurkar deleted the outofdepthsync branch December 7, 2022 10:02
@aloknerurkar aloknerurkar added this to the 1.10.0 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants