feat: introduce min estimated gas limit #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloknerurkar
approved these changes
Dec 2, 2022
mrekucci
force-pushed
the
fix_gas_limit
branch
2 times, most recently
from
a951df5
to
9915106
Compare
mrekucci
changed the title
istae
requested changes
Dec 2, 2022
| Data: callData, | ||
| GasPrice: sctx.GetGasPrice(ctx), | ||
| GasLimit: sctx.GetGasLimit(ctx), | ||
| MinEstimatedGasLimit: 500_000, |
There was a problem hiding this comment.
@mrekucci can we add this to all the other calls in this pkg?
mrekucci
force-pushed
the
fix_gas_limit
branch
from
9915106
to
7648f73
Compare
istae
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Introduces the possibility to specify a minimum gas limit for a transaction in case the gas limit is estimated.
This change is