Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new localstore migration to reset gcSize #3595

Merged
merged 2 commits into from Nov 28, 2022
Merged

fix: new localstore migration to reset gcSize #3595

merged 2 commits into from Nov 28, 2022

Conversation

aloknerurkar
Copy link
Contributor

@aloknerurkar aloknerurkar commented Nov 28, 2022

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Reset the gcSize to gcIndex. Currently, we have chunks lying in the localstore gcIndex that may not be accounted for in the gcSize calculation as these were fixed recently.

This migration resets the gcSize to force a gc eviction in the node and clean up the stale entries. This along with the new reserveSize calculation should cleanup the data from localstore.


This change is Reviewable

Copy link
Member

@istae istae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated var DBSchemaCurrent = DBSchemaSharky

)

// DBSchemaCatharsis is the bee schema identifier for resetting gcIndex.
const DBSchemaCatharsis = "catharsis"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very dramatic name :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beginning of the cleansing!

@istae istae merged commit e27aff2 into master Nov 28, 2022
@istae istae deleted the catharsis.0 branch November 28, 2022 15:36
@aloknerurkar aloknerurkar added this to the 1.10.0 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants