Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify gc size calculation #3591

Merged
merged 1 commit into from Nov 28, 2022
Merged

fix: simplify gc size calculation #3591

merged 1 commit into from Nov 28, 2022

Conversation

aloknerurkar
Copy link
Contributor

@aloknerurkar aloknerurkar commented Nov 28, 2022 •
edited by acud

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

This is a minor change to use the gcSizeChange as the number for eviction count and not use the separate reserveSize calculation which was recently removed.

Also, added a new metric to show the eviction count.

This change is Reviewable

@aloknerurkar aloknerurkar merged commit ea2c721 into master Nov 28, 2022
@aloknerurkar aloknerurkar deleted the gcCalculation.0 branch November 28, 2022 12:21
@aloknerurkar aloknerurkar added this to the 1.10.0 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrekucci mrekucci mrekucci approved these changes

@istae istae istae approved these changes

@notanatol notanatol Awaiting requested review from notanatol

Assignees
No one assigned
Labels
pull-request
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aloknerurkar @mrekucci @istae