fix: gc to continue on retrieval error #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istae
requested review from
a team,
mrekucci,
notanatol and
aloknerurkar
and removed request for
a team
istae
changed the title
istae
changed the title
pkg/localstore/mode_put.go
Outdated
| @@ -466,6 +466,11 @@ func (db *DB) addToCache( | |||
| batch *leveldb.Batch, | |||
| item shed.Item, | |||
| ) (int64, error) { | |||
|
|
|||
| err := db.pullIndex.DeleteInBatch(batch, item) | |||
There was a problem hiding this comment.
So moving these doesnt make any difference. The index is only updated when the Batch is written. So order doesnt matter.
There was a problem hiding this comment.
Here we have early returns from the function due to the pin check, this should not affect the chunk being removed from the reserve.
There was a problem hiding this comment.
So on L481 we return if there is an existing pinIndex. In this case, we dont put the item to gcIndex and hence we should not delete the pullIndex.
pkg/localstore/mode_set.go
Outdated
| @@ -365,6 +365,10 @@ func (db *DB) setUnpin(batch *leveldb.Batch, addr swarm.Address) (gcSizeChange i | |||
| item.StoreTimestamp = i.StoreTimestamp | |||
| item.BinID = i.BinID | |||
| item.BatchID = i.BatchID | |||
| err = db.pullIndex.DeleteInBatch(batch, item) | |||
There was a problem hiding this comment.
so here if an item is in the pushIndex, it should not affect the reserve, this is why it's moved above the pushIndex check.
aloknerurkar
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
This change is