Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unreserve batch to start from bin 0 #3584

Merged
merged 5 commits into from Nov 24, 2022
Merged

fix: unreserve batch to start from bin 0 #3584

merged 5 commits into from Nov 24, 2022

Conversation

istae
Copy link
Member

@istae istae commented Nov 24, 2022

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

With this change, batch eviction will start from radius zero which guarantees that ALL chunks up to radius are evicted.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):


This change is Reviewable

@istae istae requested review from a team, mrekucci and aloknerurkar and removed request for a team November 24, 2022 15:49
pkg/localstore/reserve.go Outdated Show resolved Hide resolved
@istae istae merged commit 3e5137d into master Nov 24, 2022
@istae istae deleted the unreserve-fix branch November 24, 2022 18:56
@aloknerurkar aloknerurkar added this to the 1.10.0 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants