Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puller rate incorrectly blocks Schelling game #3576

Closed
ldeffenb opened this issue Nov 23, 2022 · 0 comments · Fixed by #3579
Closed

Puller rate incorrectly blocks Schelling game #3576

ldeffenb opened this issue Nov 23, 2022 · 0 comments · Fixed by #3579
Labels
issue needs-triaging new issues that need triaging

Comments

@ldeffenb
Copy link
Collaborator

Context

bee 1.10 rc*

Summary

My testnet bee nodes quit participating in the storage-incentives because they are showing a non-zero sync rate, but yet the reserve size reported by depthmonitor is not changing.

Expected behavior

If the reserve is not changing size, I would expect the node to consider itself synced and participate in the storage incentives Schelling game.

Actual behavior

The node stops participating with a non-zero sync rate.

Steps to reproduce

Just watch the depthmonitor logs for a non-zero rate but yet a non-changing reserve size.

Possible solution

Only consider the sync rate of chunks that are within the current reserve radius instead of all pulled chunks which are currently based on the kademlia radius which is smaller and results in an inappropriate pull sync rate preventing storage incentives.

"time"="2022-11-21 23:15:16.533182" "level"="info" "logger"="node/depthmonitor" "msg"="depthmonitor: state" "current size"=2888585 "radius"=4 "chunks/sec rate"=68.00319176666667
"time"="2022-11-21 23:20:33.012192" "level"="info" "logger"="node/depthmonitor" "msg"="depthmonitor: state" "current size"=2888585 "radius"=4 "chunks/sec rate"=69.02711146666665
"time"="2022-11-21 23:23:35.422169" "level"="info" "logger"="node/depthmonitor" "msg"="depthmonitor: IsFullySynced" "rate"=70.79577546666667 "load"=2888585 "ReserveCapacity/2"=2097152
"time"="2022-11-21 23:25:56.230649" "level"="info" "logger"="node/depthmonitor" "msg"="depthmonitor: state" "current size"=2888585 "radius"=4 "chunks/sec rate"=72.73796655555554
"time"="2022-11-21 23:31:10.532478" "level"="info" "logger"="node/depthmonitor" "msg"="depthmonitor: state" "current size"=2888585 "radius"=4 "chunks/sec rate"=71.40880284444444
"time"="2022-11-21 23:36:19.324855" "level"="info" "logger"="node/depthmonitor" "msg"="depthmonitor: state" "current size"=2888585 "radius"=4 "chunks/sec rate"=72.46796542222222 32810
@ldeffenb ldeffenb added the needs-triaging new issues that need triaging label Nov 23, 2022
@bee-runner bee-runner bot added the issue label Nov 23, 2022
@istae istae linked a pull request Nov 24, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue needs-triaging new issues that need triaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant