Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(staking): add tx hash #3573

Merged
merged 2 commits into from Nov 24, 2022
Merged

feat(staking): add tx hash #3573

merged 2 commits into from Nov 24, 2022

Conversation

umerm-work
Copy link
Contributor

@umerm-work umerm-work commented Nov 22, 2022

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

The PR adds transaction hash to the staking API.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

#3359


This change is Reviewable

@umerm-work umerm-work force-pushed the add_tx_hash branch 2 times, most recently from f5e827a to dcdbd8f Compare November 22, 2022 15:17
@umerm-work umerm-work self-assigned this Nov 22, 2022
@umerm-work umerm-work added the ready for review The PR is ready to be reviewed label Nov 22, 2022
pkg/storageincentives/staking/contract.go Outdated Show resolved Hide resolved
pkg/storageincentives/staking/contract.go Outdated Show resolved Hide resolved
pkg/storageincentives/staking/contract.go Outdated Show resolved Hide resolved
pkg/api/staking.go Outdated Show resolved Hide resolved
@umerm-work umerm-work added this to the 1.9.0 milestone Nov 24, 2022
@umerm-work umerm-work merged commit c45c0d8 into master Nov 24, 2022
@umerm-work umerm-work deleted the add_tx_hash branch November 24, 2022 14:24
@aloknerurkar aloknerurkar modified the milestones: 1.9.0, 1.10.0 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants