Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wallet address #3571

Merged
merged 1 commit into from Nov 23, 2022
Merged

feat: add wallet address #3571

merged 1 commit into from Nov 23, 2022

Conversation

umerm-work
Copy link
Contributor

@umerm-work umerm-work commented Nov 22, 2022

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Closes #3569

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):


This change is Reviewable

@umerm-work umerm-work self-assigned this Nov 22, 2022
@umerm-work umerm-work added this to the 1.9.0 milestone Nov 22, 2022
@umerm-work umerm-work added the ready for review The PR is ready to be reviewed label Nov 22, 2022
pkg/api/wallet.go Outdated Show resolved Hide resolved
pkg/api/wallet.go Outdated Show resolved Hide resolved
@umerm-work umerm-work requested review from istae and a user November 22, 2022 12:52
@mrekucci
Copy link
Contributor

The changes need to be reflected in the OpenAPI spec.

Copy link
Member

@agazso agazso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@umerm-work
Copy link
Contributor Author

The changes need to be reflected in the OpenAPI spec.

Thanks for pointing. Added.

@umerm-work umerm-work merged commit ac8c44e into master Nov 23, 2022
@umerm-work umerm-work deleted the add_wallet_address branch November 23, 2022 12:42
@aloknerurkar aloknerurkar modified the milestones: 1.9.0, 1.10.0 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wallet address to the /wallet endpoint
5 participants