fix: relax reserve eviction during GC #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrekucci
reviewed
Nov 21, 2022
janos
approved these changes
Nov 21, 2022
mrekucci
reviewed
Nov 22, 2022
| target = db.reserveCapacity | ||
| } else { | ||
| reserveSizeStart, err = db.reserveSize.Get() | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
I'd recommend moving the error check also into the else block.
| if err != nil { | ||
| return 0, false, err | ||
| } | ||
| db.logger.Debug("gc: reserve eviction", "reserveSizeStart", reserveSizeStart, "target", target) |
There was a problem hiding this comment.
Using snake-case instead of camel-case for log keys is preferable.
istae
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The localstore reserve size calculation is not correct and for storage incentives, we manually calculate the syncing index to calculate the reserve size.
In the private testnet we observed that the reserve eviction was causing some inconsistencies in the samples generated. During GC, we evict chunks from the reserve till we reach 90% capacity and move them to the cache. As we no longer consider cache chunks in the sample calculation, we have decided to relax the eviction till we are at 100% capacity. So, only evict if we have more chunks.
Also, as the storage radius is now dynamic, we will need to calculate the reserve size using the current radius during eviction. This might lead to node having to store some more data, but eventually, all the expiring batches should be cleaned up.
This change is