fix(puller): increment from value on successful sync only and sleep only on connection error #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istae
changed the title
notanatol
approved these changes
Nov 9, 2022
mrekucci
approved these changes
Nov 9, 2022
pkg/pullsync/pullsync.go
Outdated
| @@ -303,12 +303,16 @@ func (s *Syncer) handler(streamCtx context.Context, p p2p.Peer, stream p2p.Strea | |||
| return fmt.Errorf("read get range: %w", err) | |||
| } | |||
|
|
|||
| s.logger.Debug("make offer start", "bin", rn.Bin, "from", rn.From, "to", rn.To, "peer", p.Address) | |||
There was a problem hiding this comment.
To stay consistent I'd recommend renaming "peer" to "peer_address", the same is below.
There was a problem hiding this comment.
I knew you were going to write this haha <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Puller only sleeps when there is a connection related error from sync interval.
Sync from field is only incremented when previous sync attempt and received top value are good (nonzero)
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
This change is