refactor: transactions #3502
Merged
refactor: transactions #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ralph-pichler,
metacertain and
istae
and removed request for
ralph-pichler
ghost
self-assigned this
ghost
marked this pull request as ready for review
notanatol
approved these changes
Nov 8, 2022
mrekucci
approved these changes
Nov 8, 2022
istae
reviewed
Nov 8, 2022
istae
reviewed
Nov 8, 2022
istae
requested changes
Nov 8, 2022
ghost
force-pushed
the
resolved-signer-eip
branch
from
9af73d7
to
33c9f2a
Compare
istae
reviewed
Nov 9, 2022
istae
requested changes
Nov 9, 2022
|
Also, we can debate if this PR is necessary. Maybe we do not care about storing gas fee and tip? |
It would be nice to know these values for a transaction that ends up hung for some reason. By storing them, then the /transactions API can recall them to assist in debugging. |
istae
approved these changes
Nov 10, 2022
istae
requested changes
Nov 10, 2022
istae
requested changes
Nov 10, 2022
istae
requested changes
Nov 10, 2022
istae
requested changes
Nov 10, 2022
istae
approved these changes
Nov 14, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Open API Spec Version Changes (if applicable)
SwarmCommon.yaml: Minor : 2.3.0
Motivation and Context (Optional)
Related Issue (Optional)
#3468
closes #3505
Screenshots (if appropriate):
This change is