fix: stream related metrics #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
janos
approved these changes
Oct 31, 2022
istae
approved these changes
Oct 31, 2022
mrekucci
approved these changes
Nov 1, 2022
pkg/p2p/libp2p/connections_test.go
Outdated
| @@ -543,7 +543,9 @@ func TestConnectRepeatHandshake(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| if _, err := s2.HandshakeService().Handshake(ctx, libp2p.NewStream(stream), info.Addrs[0], info.ID); err != nil { | |||
| s := s2.WrapStream(stream) | |||
There was a problem hiding this comment.
Since s is only used in the Handshake method, I would suggest nesting it there.
pkg/p2p/libp2p/libp2p.go
Outdated
| @@ -1080,6 +1084,25 @@ func (c *connectionNotifier) Connected(_ network.Network, _ network.Conn) { | |||
| c.metrics.HandledConnectionCount.Inc() | |||
| } | |||
|
|
|||
| func newStreamMetricNotify(m metrics) *streamNotifier { | |||
There was a problem hiding this comment.
I'd name it newStreamNotifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
We need metrics to see how many streams we are closing/resetting and how many closed streams libp2p library reports.
Motivation and Context (Optional)
It's likely the libp2p library does not releases the resources after a stream is closed.
Related Issue (Optional)
Closes #3439
This change is