Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect loop #3457

Merged
5 commits merged into from Oct 26, 2022
Merged

fix: redirect loop #3457

5 commits merged into from Oct 26, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 25, 2022

Checklist

  • I have read the coding guide.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

added a not found error if there was no path

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

finally closes the major issues in refactoring epic for atleast some time
w thanks to @vladopajic & @AuHau

Related Issue (Optional)

fixes #3199

Screenshots (if appropriate):


This change is Reviewable

@ghost ghost self-assigned this Oct 25, 2022
@ghost
Copy link
Author

ghost commented Oct 25, 2022

errors are due to flaky tests

@ghost ghost requested a review from aloknerurkar October 26, 2022 10:42
@ghost ghost merged commit 5036e68 into master Oct 26, 2022
@ghost ghost deleted the redirect-loop branch October 26, 2022 11:00
@aloknerurkar aloknerurkar added this to the 1.10.0 milestone Dec 8, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permanent redirect when data is not found
2 participants