fix(localstore): remove pullIndex on caching #3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notanatol
approved these changes
Oct 21, 2022
metacertain
approved these changes
Oct 21, 2022
mrekucci
approved these changes
Oct 21, 2022
|
This won't solve expired-stamp pinned chunks being present in the pull-index since they're not going into the gc because of the pin. |
janos
approved these changes
Oct 21, 2022
Yes unfortunately. As you know already the pinning is tightly tied to the other features at the moment. The storage rewrite will definitely address this problem. But for the short term, this will help others who are not using the pinning as much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Currently, the localstore indexes are not reliable to be used for logical components like the reserve, cache etc. This is a known issue and there is a storage rewrite in progress to handle that.
For the current release, in order to test storage incentives, we will change the behaviour to delete the pullIndex when a chunk is put into the gcIndex. This is because, the pullIndex is now used to create the reserve sample. The cache chunks should not be present here.
This change is