refactor(kademlia): remove hacky config usage #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladopajic
changed the title
vladopajic
force-pushed
the
refactor-kademila-removed-hacky-config-usage
branch
from
e54cf00
to
4fc17a9
Compare
vladopajic
requested review from
a team,
mrekucci and
notanatol
and removed request for
a team
vladopajic
changed the title
vladopajic
force-pushed
the
refactor-kademila-removed-hacky-config-usage
branch
from
4fc17a9
to
e31b01e
Compare
4 tasks
istae
approved these changes
Oct 13, 2022
4 tasks
notanatol
approved these changes
Oct 18, 2022
mrekucci
pushed a commit
that referenced
this pull request
Oct 20, 2022
This reverts commit 9f93ee8.
mrekucci
pushed a commit
that referenced
this pull request
Oct 20, 2022
This reverts commit 9f93ee8.
mrekucci
pushed a commit
that referenced
this pull request
Oct 20, 2022
This reverts commit 9f93ee8.
mrekucci
pushed a commit
that referenced
this pull request
Oct 20, 2022
This reverts commit 9f93ee8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
kademilapackage had hacky way for test configuration. In this PR kademila options were extended to allow other optional parameters to be set.This change is