From 4fde41dc18ae0e0a96f1df68924e2bb89b8dab6f Mon Sep 17 00:00:00 2001 From: istae <14264581+istae@users.noreply.github.com> Date: Thu, 20 Oct 2022 13:48:22 +0300 Subject: [PATCH] fix: missing metric --- pkg/puller/puller.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/puller/puller.go b/pkg/puller/puller.go index 189db06fe67..56d0b5a5252 100644 --- a/pkg/puller/puller.go +++ b/pkg/puller/puller.go @@ -274,8 +274,8 @@ func (p *Puller) histSyncWorker(ctx context.Context, peer swarm.Address, bin uin return } if syncErr != nil { - p.logger.Error(err, "histSyncWorker syncing interval failed", "peer_address", peer, "bin", bin, "cursor", cur, "start", s, "topmost", top) - continue + p.metrics.HistWorkerErrCounter.Inc() + p.logger.Error(syncErr, "histSyncWorker syncing interval failed", "peer_address", peer, "bin", bin, "cursor", cur, "start", s, "topmost", top) } loggerV2.Debug("histSyncWorker pulled", "bin", bin, "start", s, "topmost", top, "peer_address", peer) @@ -325,9 +325,8 @@ func (p *Puller) liveSyncWorker(ctx context.Context, peer swarm.Address, bin uin if syncErr != nil { p.metrics.LiveWorkerErrCounter.Inc() - p.logger.Error(err, "liveSyncWorker sync error", "peer_address", peer, "bin", bin, "from", from, "topmost", top) + p.logger.Error(syncErr, "liveSyncWorker sync error", "peer_address", peer, "bin", bin, "from", from, "topmost", top) sleep = true - continue } loggerV2.Debug("liveSyncWorker pulled bin", "bin", bin, "from", from, "topmost", top, "peer_address", peer)