Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix variable that isn't in scope #1626

Closed
wants to merge 1 commit into from
Closed

fix variable that isn't in scope #1626

wants to merge 1 commit into from

Conversation

JoviDeCroock
Copy link

Fixes #1624

@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label May 29, 2021
ricmoo added a commit that referenced this pull request May 31, 2021
@ricmoo
Fixed broken variable in template string (#1624, #1626).
630656e
@ricmoo
Copy link
Member

ricmoo commented Jun 1, 2021

Merged in 5.3.0.

Thanks! :)

@ricmoo ricmoo closed this Jun 1, 2021
@ricmoo ricmoo added bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jun 1, 2021
pull bot pushed a commit to shapeshift/ethers.js that referenced this pull request Jun 4, 2021
@ricmoo @pull
Fixed broken variable in template string (ethers-io#1624, ethers-io#1626
7ea46d2 
).
pull bot pushed a commit to shapeshift/ethers.js that referenced this pull request Jun 4, 2021
@ricmoo @pull
Fixed broken variable in template string (ethers-io#1624, ethers-io#1626
9729201 
).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find name 'name'. Did you mean the static member 'BaseContract.name'?
2 participants
@JoviDeCroock @ricmoo