Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find name 'name'. Did you mean the static member 'BaseContract.name'? #1624

Closed
chebykin opened this issue May 29, 2021 · 2 comments
Closed
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@chebykin
Copy link

Describe the bug

While compiling using tsc or webpack i'm getting the following error:

node_modules/@ethersproject/contracts/src.ts/index.ts:696:72 - error TS2662: Cannot find name 'name'. Did you mean the static member 'BaseContract.name'?

696                 logger.warn(`Duplicate ABI entry for ${ JSON.stringify(name) }`);
                                                                           ~~~~

This points me here

logger.warn(`Duplicate ABI entry for ${ JSON.stringify(name) }`);

Can't find a proper workaround, just replaced this name with a string for now to suppress this compiler warning.

Reproduction steps

  • include the following packages into package.json
"@typechain/ethers-v5": "^7.0.0",
"ethers": "^5.0.18",
"@ethersproject/abstract-signer": "^5.0.1",
"@ethersproject/bignumber": "^5.0.3"
  • try to bundle using either tsc or webpack

Environment:

  • Node.js
  • Typescript
@chebykin chebykin added the investigate Under investigation and may be a bug. label May 29, 2021
@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label May 29, 2021
@ricmoo
Copy link
Member

ricmoo commented May 29, 2021

This looks like a bug to me. I’ll take a look at it as soon as possible. Thanks! :)

@ricmoo ricmoo added bug Verified to be an issue. and removed investigate Under investigation and may be a bug. labels May 31, 2021
@ricmoo
Copy link
Member

ricmoo commented Jun 1, 2021

Fixed in 5.3.0. Try it out and let me know if you still have any issues.

Thanks! :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jun 1, 2021
pull bot pushed a commit to shapeshift/ethers.js that referenced this issue Jun 4, 2021
pull bot pushed a commit to shapeshift/ethers.js that referenced this issue Jun 4, 2021
@ricmoo ricmoo closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants