Update test suite, update Solidity contract version, remove deprecated JSON-RPC methods #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Mar 29, 2024
fselmo
force-pushed
the
recompile-test-contracts-with-0.8.25
branch
from
1989108
to
b69d66a
Compare
fselmo
changed the title
v0.8.25
fselmo
force-pushed
the
recompile-test-contracts-with-0.8.25
branch
from
4465127
to
1994dfe
Compare
fselmo
changed the title
v0.8.25
fselmo
force-pushed
the
recompile-test-contracts-with-0.8.25
branch
from
1994dfe
to
747e932
Compare
- ``eth_coinbase`` - ``eth_mining`` - ``eth_hashrate`` - ``eth_submitHashrate`` - ``eth_submitWork`` - ``eth_getWork``
fselmo
force-pushed
the
recompile-test-contracts-with-0.8.25
branch
from
747e932
to
8c52a4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
This PR was meant to update Solidity contract versions but it revealed that
geth --devwas broken. Geth fixed this and this PR brings those changes in (v1.14.3). Updated geth no longer has support foreth_mining,eth_hashrate,eth_submitWork,eth_getWork,eth_coinbase... nor does it support thependingblock anymore. This PR gets our test suite updated with all of these changes as well as removes support for those methods altogether. We will have to issue a backport PR forv6to deprecate all of these.v1.14.3eth-tester[py-evm]to0.10.0b.4eth_mining,eth_hashrate,eth_submitHashrate,eth_submitWork,eth_getWork,eth_coinbasependingblockTodo:
Cute Animal Picture
0_o