New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move get_event_data
and get_function_info
from web3._utils modules to Public API
#1596
Comments
@MikeHathaway can you provide your use case for why you couldn't use |
I encountered the same "problem". I receive a bunch of events from different contracts types at different addresses. I have a means to get the abi of the event from the log, and used to get the processed event with something like:
Since the way
I agree that I could change this in my code by getting the contract and its abi instead of just the event abi upon receiving the log, but it seems unnecessary. |
Thanks for the code snippet @cducrest, that helps a lot! I don't see any reason why this wouldn't be able to go in the v6 release. Added to the v6 issue! |
We can do this in the v5 line. This isn't a breaking change since it would just be exposing some previously private APIs as public. |
doh, true. Thanks @pipermerriam! |
I'd be more inclined to keep it in I don't have context for another use case, though, open to discuss. |
What was wrong?
Breaking changes were made to utility functions depended upon for client application functionality, making version updates more difficult.
How can it be fixed?
Python clients are using utility functions such as
get_event_data
andget_function_info
extensively to interact with the blockchain. Given their utility to clients, these functions should be moved out of the_utils
module and made public to ensure API stability across non-major releases.The text was updated successfully, but these errors were encountered: