Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for tracing module methods #2894

Open
fselmo opened this issue Mar 24, 2023 · 0 comments
Open

Add tests for tracing module methods #2894

fselmo opened this issue Mar 24, 2023 · 0 comments

Comments

@fselmo
Copy link
Collaborator

fselmo commented Mar 24, 2023

What was wrong?

  • Add tracing methods again #2851 re-introduced the tracing module along with the trace functionality back into the codebase. We manually tested to merge that but we should have tests around those methods so we know when they might break. This is a bookkeeping issue for us to add these tests when we have some time to.

How can it be fixed?

  • Add testing for the tracing module. Ideally these tests will be updatable with each new version of Nethermind or Erigon. This may be a script that records static responses to calls and can be run again to re-generate the responses when a new version comes out. Or it can be something else entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant