Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify provider usage in Quickstart docs #2287

Merged
merged 1 commit into from Jan 3, 2022
Merged

Clarify provider usage in Quickstart docs #2287

merged 1 commit into from Jan 3, 2022

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Jan 3, 2022 •
edited

What was wrong?

  • no mention of eth-tester, which is optimal for most early explorers.
  • Geth deserves highlighting, but not given exclusivity.
  • Infura deserves mention, but not given exclusivity.
  • Websockets example domains off by one 's'

How was it fixed?

With words!

Todo:

Cute Animal Picture

pacrob
pacrob approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin' good, no changes from me

@wolovim wolovim merged commit e529a00 into ethereum:master Jan 3, 2022
@wolovim wolovim deleted the onboard-docs-1 branch January 3, 2022 23:45
@fselmo
Copy link
Collaborator

fselmo commented Jan 3, 2022

I like these changes 👌. We needed some updating here 📈

@fselmo fselmo mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@kclowes kclowes Awaiting requested review from kclowes

@fselmo fselmo Awaiting requested review from fselmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wolovim @fselmo @pacrob