Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removed property to Log type (#4877) #5576

Merged
merged 1 commit into from Oct 28, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Oct 28, 2022

This PR is for e2e tests of #4877

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

* Add `removed` property to `Log` type

Fixes #4747 (comment)

* Update CHANGELOG.md

added this upon jdevcs' [request](#4877 (comment))

* Update CHANGELOG.md

Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
@jdevcs jdevcs self-assigned this Oct 28, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3344804460

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 436 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.233%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 2 82.76%
packages/web3-core-helpers/src/formatters.js 25 80.8%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 58 36.89%
packages/web3-utils/src/utils.js 96 13.31%
packages/web3-eth-accounts/src/index.js 169 23.35%
Totals Coverage Status
Change from base Build 3304597042: -2.3%
Covered Lines: 3414
Relevant Lines: 4445

💛 - Coveralls

@jdevcs
Copy link
Contributor Author

jdevcs commented Oct 28, 2022

All changes in this PR are approved in #4877 so merging into 1.x

@jdevcs jdevcs merged commit 32b4c79 into 1.x Oct 28, 2022
@jdevcs jdevcs deleted the junaid/removedpropertytologtypee2etest branch October 28, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants