docs: Fix example of tx usage #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevcs
requested changes
Aug 31, 2022
jdevcs
added
1.x
avkos
requested changes
Sep 6, 2022
|
@avkos Done! |
avkos
approved these changes
Sep 6, 2022
jdevcs
reviewed
Sep 6, 2022
jdevcs
reviewed
Sep 7, 2022
CHANGELOG.md
Outdated
Comment on lines
7
to
36
| <!-- EXAMPLE | ||
|
|
||
| ## [1.0.0] | ||
|
|
||
| ### Added | ||
|
|
||
| - I've added feature XY (#1000) | ||
|
|
||
| ### Changed | ||
|
|
||
| - I've cleaned up XY (#1000) | ||
|
|
||
| ### Deprecated | ||
|
|
||
| - I've deprecated XY (#1000) | ||
|
|
||
| ### Removed | ||
|
|
||
| - I've removed XY (#1000) | ||
|
|
||
| ### Fixed | ||
|
|
||
| - I've fixed XY (#1000) | ||
|
|
||
| ### Security | ||
|
|
||
| - I've improved the security in XY (#1000) | ||
|
|
||
| --> | ||
|
|
There was a problem hiding this comment.
This example template shouldn't be removed.
There was a problem hiding this comment.
Sorry, removed it in error. I've added it back
|
This PR is doc change so can merge without status of all CI actions. |
Merged
This was referenced Oct 23, 2022
This was referenced Jan 2, 2023
This was referenced Feb 15, 2023
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes documentation of @ethereumjs/tx usage in the code example for
eth_sendSignedTransactionType of change
CHANGELOG.mdfile in the root folder.