Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs update #4860

Merged
merged 3 commits into from Mar 17, 2022
Merged

libs update #4860

merged 3 commits into from Mar 17, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Mar 16, 2022 •
edited

Description

#4840

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs added the 1.x 1.0 related issues label Mar 16, 2022
@jdevcs jdevcs self-assigned this Mar 16, 2022
@render
Copy link

render bot commented Mar 16, 2022

Your Render PR Server URL is https://web3-js-pr-4860.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8p5nnnh8vl4ihsrjd3g.

@jdevcs jdevcs changed the title libs update - npm audit fix libs update Mar 16, 2022
@jdevcs jdevcs marked this pull request as ready for review March 16, 2022 21:56
jdevcs
jdevcs commented Mar 16, 2022
View reviewed changes
CHANGELOG.md

### Fixed
- Fix jsonrpc payload and response types (#4743) (#4761)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs 4743 4761 were not released under 1.7.1, https://github.com/ChainSafe/web3.js/releases/tag/v1.7.1

@jdevcs jdevcs added the Review Needed Maintainer(s) need to review label Mar 16, 2022
@coveralls
Copy link

coveralls commented Mar 16, 2022 •
edited

Pull Request Test Coverage Report for Build 1995323748

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 429 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.2%) to 72.756%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 1975083195: -2.2%
Covered Lines: 3387
Relevant Lines: 4397
💛 - Coveralls

@spacesailor24 spacesailor24 merged commit 16fdf72 into 1.x Mar 17, 2022
@spacesailor24 spacesailor24 deleted the junaid/updateLibs4840 branch March 17, 2022 07:14
@ghost ghost mentioned this pull request Mar 18, 2022
Merged
16 tasks
@jdevcs jdevcs mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacesailor24 spacesailor24 spacesailor24 approved these changes

@luu-alex luu-alex luu-alex approved these changes

@nazarhussain nazarhussain Awaiting requested review from nazarhussain

@avkos avkos Awaiting requested review from avkos avkos is a code owner

@nikoulai nikoulai Awaiting requested review from nikoulai

Assignees

@jdevcs jdevcs

Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdevcs @coveralls @spacesailor24 @luu-alex