Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now we can remove the close event (#4825) #4839

Merged
merged 6 commits into from Mar 17, 2022
Merged

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Mar 10, 2022

Following #4786

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs added the 1.x 1.0 related issues label Mar 10, 2022
@jdevcs jdevcs self-assigned this Mar 10, 2022
@render
Copy link

render bot commented Mar 10, 2022

@coveralls
Copy link

coveralls commented Mar 10, 2022

Pull Request Test Coverage Report for Build 1999494516

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 450 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-2.8%) to 72.21%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/lib/errors.js 2 79.41%
packages/web3-core-subscriptions/lib/subscription.js 2 90.37%
packages/web3-core-requestmanager/lib/index.js 17 72.89%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 1999461585: -2.8%
Covered Lines: 3368
Relevant Lines: 4396

💛 - Coveralls

@jdevcs jdevcs linked an issue Mar 10, 2022 that may be closed by this pull request
1 task
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated event listener
6 participants