e2e_gnosis_dex mute #4701
Merged
e2e_gnosis_dex mute #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://web3-js-pr-4701.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7g3n2c6fj3ffl60naq0. |
Pull Request Test Coverage Report for Build 1712441871
💛 - Coveralls |
|
i think it would be good to create a note about why we are doing this, either as a comment in build.yml we are disabling it and adding it to changelog |
luu-alex
approved these changes
Jan 16, 2022
nazarhussain
approved these changes
Jan 18, 2022
Comment on lines
+59
to
+63
| #elif [ "$TEST" = "e2e_gnosis_dex" ]; then | ||
| # | ||
| # npm run test:e2e:publish | ||
| # npm run test:e2e:gnosis:dex | ||
| # |
There was a problem hiding this comment.
You don't need to comment these, as it will not be executed by CI server anyway.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed e2e gnosis test in CI is being muted in this PR, until fixed.
#4436
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.