Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in web3-utils.rst #4662

Merged
merged 6 commits into from Jan 19, 2022
Merged

Fix typos in web3-utils.rst #4662

merged 6 commits into from Jan 19, 2022

Conversation

GitHubPang
Copy link

Description

A bunch of typo fixes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@nazarhussain nazarhussain added 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Jan 6, 2022
@jdevcs
Copy link
Contributor

jdevcs commented Jan 13, 2022

@GitHubPang this branch is out of date with base branch, could you merge changes from 1.x into your feature branch?

@jdevcs jdevcs added the Documentation Relates to project wiki or documentation label Jan 14, 2022
@jdevcs jdevcs mentioned this pull request Jan 14, 2022
4 tasks
@jdevcs
Copy link
Contributor

jdevcs commented Jan 14, 2022

@GitHubPang Thanks for your contribution,
Before we merge it, could you update change log

@jdevcs jdevcs merged commit 8a87aef into web3:1.x Jan 19, 2022
@GitHubPang GitHubPang deleted the patch-2 branch January 19, 2022 23:50
@jdevcs jdevcs mentioned this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants