Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo #4599

Merged
merged 3 commits into from Dec 17, 2021
Merged

Fix a typo #4599

merged 3 commits into from Dec 17, 2021

Conversation

chenxsan
Copy link

@chenxsan chenxsan commented Dec 5, 2021

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue) closes A typo in docs #4616
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Seems a whitespace is needed to render the code part correctly:

CleanShot 2021-12-05 at 18 43 18@2x

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@nazarhussain nazarhussain added the 1.x 1.0 related issues label Dec 9, 2021
@nazarhussain
Copy link
Contributor

@chenxsan Thanks a lot for your contribution. The change seems good, I assigned some reviewers to get this approved so we can merge it.

Meanwhile I would request you to create an issue on and link your PR with that issue. Also create an entry into CHANGELOG.md file in your PR, mentioning what is fixed.

@nazarhussain nazarhussain added Changes Requested Requires further changes Review Needed Maintainer(s) need to review labels Dec 9, 2021
@luu-alex luu-alex linked an issue Dec 14, 2021 that may be closed by this pull request
1 task
@nazarhussain nazarhussain self-assigned this Dec 17, 2021
@nazarhussain nazarhussain removed Review Needed Maintainer(s) need to review Changes Requested Requires further changes labels Dec 17, 2021
@nazarhussain nazarhussain changed the base branch from 1.x to 4.x December 17, 2021 13:39
@nazarhussain nazarhussain changed the base branch from 4.x to 1.x December 17, 2021 13:39
@nazarhussain nazarhussain changed the base branch from 1.x to nh/4616-docs-typo December 17, 2021 14:18
@nazarhussain nazarhussain changed the base branch from nh/4616-docs-typo to 1.x December 17, 2021 14:24
@jdevcs jdevcs changed the base branch from 1.x to nh/4616-docs-typo December 17, 2021 14:37
@jdevcs jdevcs merged commit 744e7fd into web3:nh/4616-docs-typo Dec 17, 2021
@chenxsan chenxsan deleted the patch-1 branch December 17, 2021 15:30
jdevcs pushed a commit that referenced this pull request Dec 17, 2021
* Empty commit to trigger CI

* Fix a typo (#4599)

* Fix a typo

* update changelog

Co-authored-by: Nazar Hussain <nazarhussain@gmail.com>

* 📝 Update the chanelog for 1.7.1

Co-authored-by: Sam Chen <chenxsan@gmail.com>
@jdevcs jdevcs mentioned this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A typo in docs
4 participants