Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing e2e_gnosis_dex test #4436

Closed
1 task done
spacesailor24 opened this issue Oct 6, 2021 · 1 comment
Closed
1 task done

Failing e2e_gnosis_dex test #4436

spacesailor24 opened this issue Oct 6, 2021 · 1 comment
Assignees
Labels
1.x 1.0 related issues Bug Addressing a bug

Comments

@spacesailor24
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Testing is failing with:

ERROR in /home/runner/work/web3.js/web3.js/dex-react/src/api/wallet/WalletApiMock.ts
ERROR in /home/runner/work/web3.js/web3.js/dex-react/src/api/wallet/WalletApiMock.ts(33,27):
TS2769: No overload matches this call.
  Overload 1 of 2, '(val: BN, unit?: "noether" | "wei" | "kwei" | "Kwei" | "babbage" | "femtoether" | "mwei" | "Mwei" | "lovelace" | "picoether" | "gwei" | "Gwei" | "shannon" | "nanoether" | "nano" | "szabo" | ... 11 more ... | undefined): BN', gave the following error.
    Argument of type 'import("/home/runner/work/web3.js/web3.js/dex-react/node_modules/@types/bn.js/index")' is not assignable to parameter of type 'import("/home/runner/work/web3.js/web3.js/dex-react/node_modules/web3-utils/node_modules/@types/bn.js/index")'.
      Property 'modrn' is missing in type 'import("/home/runner/work/web3.js/web3.js/dex-react/node_modules/@types/bn.js/index")' but required in type 'import("/home/runner/work/web3.js/web3.js/dex-react/node_modules/web3-utils/node_modules/@types/bn.js/index")'.
  Overload 2 of 2, '(val: string, unit?: "noether" | "wei" | "kwei" | "Kwei" | "babbage" | "femtoether" | "mwei" | "Mwei" | "lovelace" | "picoether" | "gwei" | "Gwei" | "shannon" | "nanoether" | "nano" | "szabo" | ... 11 more ... | undefined): string', gave the following error.
    Argument of type 'BN' is not assignable to parameter of type 'string'.

Expected Behavior

Test was passing previous to 1.6.0 release. Don't think it's directly related to 1.6.0 changes, but not sure what caused it to be an issue now. My best guess as to what's going wrong after doing some debugging

Steps to Reproduce

Run the test suite on 1.x

Web3.js Version

1.6.0

Environment

  • Operating System:
  • Browser:
  • Node.js Version:
  • NPM Version:

Anything Else?

No response

@spacesailor24 spacesailor24 added Bug Addressing a bug 1.x 1.0 related issues labels Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Dec 6, 2021
@jdevcs jdevcs removed the Stale Has not received enough activity label Dec 6, 2021
@jdevcs jdevcs mentioned this issue Jan 13, 2022
16 tasks
jdevcs added a commit that referenced this issue Jan 18, 2022
* e2e_gnosis_dex mute until #4436 closed
@jdevcs jdevcs closed this as completed Jan 19, 2022
@jdevcs jdevcs mentioned this issue Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

No branches or pull requests

2 participants