Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Transaction and TransactionConfig types #4232

Conversation

alexandresobolevski
Copy link

@alexandresobolevski alexandresobolevski commented Aug 11, 2021

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

EIP1559 support for sendTransaction was added link but the types were not updated to reflect the changes.

This PR adds maxPriorityFeePerGas and maxFeePerGas to TransactionConfig and Transaction.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@philknows philknows added the 1.x 1.0 related issues label Aug 31, 2021
@jdevcs jdevcs mentioned this pull request Sep 2, 2021
@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Oct 31, 2021
@philknows philknows removed the Stale Has not received enough activity label Nov 2, 2021
@jdevcs jdevcs changed the base branch from 1.x to junaid/update-transaction-transactionconfig-types-4232 November 16, 2021 12:16
@jdevcs
Copy link
Contributor

jdevcs commented Nov 16, 2021

@alexandresobolevski there are merge conflicts could you fix changelog in your branch?

@jdevcs jdevcs self-requested a review November 16, 2021 12:20
@jdevcs jdevcs merged commit e8d8d04 into web3:junaid/update-transaction-transactionconfig-types-4232 Nov 29, 2021
jdevcs added a commit that referenced this pull request Nov 29, 2021
jdevcs added a commit that referenced this pull request Nov 30, 2021
* Updates Transaction and TransactionConfig types (#4232) #4585
* Updates CHANGELOG.md
@spacesailor24 spacesailor24 mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants