Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the görli testnet ENS registry to the known registries #3338

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Jan 24, 2020

Description

This PR does add the Görli testnet ENS registry to the ENS config file.

Fixes #3252

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added Enhancement Includes improvements or optimizations 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Jan 24, 2020
@coveralls
Copy link

coveralls commented Jan 24, 2020

Coverage Status

Coverage remained the same at 85.466% when pulling c948aad on issue/3252 into 0b657c2 on 1.x.

Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

packages/web3-eth-ens/src/config.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ENS support for Goerli testnet
3 participants