Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some test case names not unique #186

Open
cdetrio opened this issue Jun 17, 2017 · 5 comments
Open

some test case names not unique #186

cdetrio opened this issue Jun 17, 2017 · 5 comments

Comments

@cdetrio
Copy link
Member

cdetrio commented Jun 17, 2017

Non-unique test names are inconvenient since it requires printing the whole path in order to distinguish test cases in results. For instance, the name callcallcallcode_001 is used for three different test cases: stCallCodes, stCallDelegateCodesCallCodeHomestead, and stCallDelegateCodesHomestead.

@winsvega
Copy link
Collaborator

winsvega commented Jun 18, 2017

thats because of a copypaste that was used back when those tests were created.
Actually I suppose that now with generalStateTests we could merge some copied tests back together.
(but that would requie a lot of work)

as for the test names. you could manually rename such tests. there are so many tests in those test cases so I didn't bother with the test names from some point.
the tests are all combinations of call callcode delegatecall between themselves

@qbzzt
Copy link
Collaborator

qbzzt commented Mar 1, 2021

#786

@winsvega
Copy link
Collaborator

winsvega commented Mar 1, 2021

786 does not solve this.

@qbzzt
Copy link
Collaborator

qbzzt commented Mar 3, 2021

Oops, you're right - my bad.

Is the problem in the Filler files, or the Filled files that are actually used to run the tests? If the second then retesteth could take care of it by including a unique identifier (for example, the first four bytes of the hash of the pathname).

@winsvega
Copy link
Collaborator

winsvega commented Mar 3, 2021

The problem was is copy paste. We actually need to review tests and rename same tests. (Different folder, same name)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants