You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While --sim.limit is useful, we have been setting up some hive suites to run as github actions, and some test suites are not yet applicable, and should be excluded.
For example, snap in the devp2p simulator is not yet applicable because we do not support the snap subprotocol yet. The sim.limit does accept a regular expression, but the golang regular expression library does not support negative lookaheads / lookbehinds. To exclude a suite, we have to explicitly include every other suite. To exclude a test, we have to explicitly include every other test.
To exclude snap, we have to run --sim.limit for each suite we want to include in devp2p, which is luckily only discv4 and eth.
I think it makes sense to allow both--sim.limit and --sim.exclude for this use case, for example:
hive --clients reth --sim devp2p --sim.limit eth --sim.exclude /TestBlockHashAnnounce
Because reth does not process block hash announcements, this would exclude the right test, while allowing us to run all other tests in eth. Without sim.exclude, we would have to enumerate all tests we want to include using the sim.limit flag.
Does this make sense?
The text was updated successfully, but these errors were encountered:
While
--sim.limit
is useful, we have been setting up some hive suites to run as github actions, and some test suites are not yet applicable, and should be excluded.For example,
snap
in thedevp2p
simulator is not yet applicable because we do not support thesnap
subprotocol yet. Thesim.limit
does accept a regular expression, but the golang regular expression library does not support negative lookaheads / lookbehinds. To exclude a suite, we have to explicitly include every other suite. To exclude a test, we have to explicitly include every other test.To exclude
snap
, we have to run--sim.limit
for each suite we want to include indevp2p
, which is luckily onlydiscv4
andeth
.I think it makes sense to allow both
--sim.limit
and--sim.exclude
for this use case, for example:Because reth does not process block hash announcements, this would exclude the right test, while allowing us to run all other tests in
eth
. Withoutsim.exclude
, we would have to enumerate all tests we want to include using thesim.limit
flag.Does this make sense?
The text was updated successfully, but these errors were encountered: