trie: fix range prover #24266
Merged
trie: fix range prover #24266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Jan 21, 2022
| @@ -505,7 +505,7 @@ func VerifyRangeProof(rootHash common.Hash, firstKey []byte, lastKey []byte, key | |||
| if val != nil || hasRightElement(root, firstKey) { | |||
| return false, errors.New("more entries available") | |||
| } | |||
| return hasRightElement(root, firstKey), nil | |||
| return false, nil | |||
There was a problem hiding this comment.
This looks strange. With this change, this entire clause will always return false in the first return-parameter, I think
There was a problem hiding this comment.
Edit: nevermind, I think this is fine
|
Please add the testcase too |
|
Actually, no need to add the testcase, we can merge the other PR too |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jan 21, 2022
ValentinTrinque
pushed a commit
to vegaprotocol/go-ethereum
that referenced
this pull request
Jan 25, 2022
MariusVanDerWijden
pushed a commit
to MariusVanDerWijden/go-ethereum
that referenced
this pull request
Jan 27, 2022
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24257