New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trie: test for edgecase in VerifyRangeProof #24257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR! Good find |
holiman
force-pushed
the
range-proof-test
branch
from
January 21, 2022 09:45
b5c08e2
to
094cdac
Compare
I've rebased this on master, and removed the todo left there. Should be good to go now |
holiman
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
holiman
changed the title
trie/proof: edge case for VerifyRangeProof
trie: test for edgecase in VerifyRangeProof
Jan 21, 2022
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jan 21, 2022
* trie/proof: edge case for VerifyRangeProof * more consistency with other tests in the file * trie: fix test todo Co-authored-by: Martin Holst Swende <martin@swende.se>
ValentinTrinque
pushed a commit
to vegaprotocol/go-ethereum
that referenced
this pull request
Jan 25, 2022
* trie/proof: edge case for VerifyRangeProof * more consistency with other tests in the file * trie: fix test todo Co-authored-by: Martin Holst Swende <martin@swende.se>
MariusVanDerWijden
pushed a commit
to MariusVanDerWijden/go-ethereum
that referenced
this pull request
Jan 27, 2022
* trie/proof: edge case for VerifyRangeProof * more consistency with other tests in the file * trie: fix test todo Co-authored-by: Martin Holst Swende <martin@swende.se>
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
* trie/proof: edge case for VerifyRangeProof * more consistency with other tests in the file * trie: fix test todo Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably a case where I am setting up something incorrectly, though the test fails when I remove the 1st elements of
keys
andvals
(but passes otherwise). I was hoping you could take a look, since I couldn't exactly figure it out.I'm assuming it's because there's a shared prefix on the keys, though not sure.
This is the stack trace I am getting: