Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove unused error from TxPool.Pending #23720

Merged
merged 3 commits into from Oct 13, 2021

Conversation

jwasinger
Copy link
Contributor

The method TxPool.Pending doesn't ever return an error so it makes sense to remove it from the method signature.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail.

Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are OK now.

@fjl fjl merged commit 011fe3e into ethereum:master Oct 13, 2021
@fjl fjl added this to the 1.10.10 milestone Oct 13, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 14, 2021
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants