accounts/abi/bind: refactor transact method #23719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Oct 12, 2021
fjl
changed the title
This was referenced Oct 13, 2021
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Oct 14, 2021
This fixes a bug where gas-related fields of the TransactOpts passed to transaction methods would be modified, skipping gas estimation for subsequent transactions. Co-authored-by: Yondon Fu <yondon.fu@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com>
tynes
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Oct 19, 2021
Bumps the go-ethereum dep to release v1.10.10 which fixes a bug with the transact opts where it is mutated and can cause gas estimation errors. See ethereum/go-ethereum#23719
smartcontracts
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Nov 10, 2021
Bumps the go-ethereum dep to release v1.10.10 which fixes a bug with the transact opts where it is mutated and can cause gas estimation errors. See ethereum/go-ethereum#23719
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
This fixes a bug where gas-related fields of the TransactOpts passed to transaction methods would be modified, skipping gas estimation for subsequent transactions. Co-authored-by: Yondon Fu <yondon.fu@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the transact method making it easier to read and easier to reason about.
This however results in ~ 40 lines more compared to the original method.
I would still argue that it's a valid refactor as it clearly discriminates between Dynamic and Legacy transactions.
It fixes an issue where executing a transaction would overwrite the
transactOpts, and adds a test for it.Previously the
gasEstimationwould populate thefeeCap/tipCapfields which would mean that if a second transaction would be send with the sametransactionOpts, the gas estimation would not be executed anymore.It also changes the code s.th.
transactonly queries the blockchain ifgasPriceis not specified.If
gasPriceis set, we just construct a legacy transaction. If not we query the head if basefee is already set.supersedes #23663
supersedes #23587
closes #23586