Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/jsre: handle null and undefined to prevent crash #23701

Merged
merged 1 commit into from Oct 10, 2021

Conversation

aditya520
Copy link
Contributor

Prevents the console from crashing console when auto-completing a variable that is null or undefined.

Fixes #23693

@fjl fjl changed the title jsre: completion: fixes goja null and undefined to prevent console crash internal/jsre: handle null and undefined to prevent crash Oct 10, 2021
@fjl fjl merged commit a6a0609 into ethereum:master Oct 10, 2021
@fjl fjl added this to the 1.10.10 milestone Oct 10, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 11, 2021
…3701)

This prevents the console from crashing when auto-completing on
a variable or property that is null or undefined.

Fixes ethereum#23693
@aditya520 aditya520 deleted the fix_console_crash branch April 1, 2022 00:46
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
…3701)

This prevents the console from crashing when auto-completing on
a variable or property that is null or undefined.

Fixes ethereum#23693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] tab completion on an undefined variable cause crash
2 participants