Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/evm: stricter transaction validation #23694

Merged
merged 2 commits into from Oct 11, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Oct 7, 2021

This PR fixes #23668

It adds intrinsic gas-checks to t9n transaction validation. Also, it returns as much as possible known about the transaction:

  • If the tx is sufficiently correct, so that it can be interpreted as a transaction, we output the hash,
  • If it's also sufficienty correct, so that a signer can be derived, we output the sender.
  • If the tx does not pass the intrinsic-gas cost, we output an error.

So, essentialy, you can have these possible combinations (per tx)

  • only error,
  • error and hash
  • error and hash and sender
  • hash and sender

@holiman
Copy link
Contributor Author

holiman commented Oct 7, 2021

cc @marioevz PTAL and give a 👍 or 👎 if it works for you

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.10 milestone Oct 11, 2021
@holiman holiman merged commit 64da037 into ethereum:master Oct 11, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 11, 2021
* cmd/evm: t9n: validate transaction intrinsic gas

* cmd/evm: t9n: stricter tx validation
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
* cmd/evm: t9n: validate transaction intrinsic gas

* cmd/evm: t9n: stricter tx validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

evm t9n should reject transactions with low gasLimit
2 participants