core: fix race conditions in txpool #23474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
reviewed
Aug 27, 2021
core/tx_list.go
Outdated
| } | ||
|
|
||
| // reheap forcibly rebuilds the heap based on the current remote transaction set. | ||
| // Expects the reheap mutex to be held |
There was a problem hiding this comment.
If the mu is only there to protect the reheap operation, perhaps rename it to reheapMu and do the lock/unlock inside of reheap instead?
There was a problem hiding this comment.
Renamed and moved
There was a problem hiding this comment.
Actually, now you can revert another change too: remove reheap again and have only Reheap.
MariusVanDerWijden
force-pushed
the
txpool-race
branch
from
bb5e723
to
8906d9c
Compare
fjl
reviewed
Aug 27, 2021
| @@ -123,6 +124,8 @@ func setupTxPoolWithConfig(config *params.ChainConfig) (*TxPool, *ecdsa.PrivateK | |||
| key, _ := crypto.GenerateKey() | |||
| pool := NewTxPool(testTxPoolConfig, config, blockchain) | |||
|
|
|||
| // wait for the pool to initialize | |||
| <-pool.initDoneCh | |||
There was a problem hiding this comment.
I don't understand this change. What's the point of waiting the loop function to start up here?
There was a problem hiding this comment.
Otherwise the resetState function race with the loop function
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Sep 1, 2021
* core: fix race conditions in txpool * core: fixed races in the txpool * core: rebased on master * core: move reheap mutex * core: renamed mutex * core: revert Reheap changes
This was referenced Sep 23, 2022
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
* core: fix race conditions in txpool * core: fixed races in the txpool * core: rebased on master * core: move reheap mutex * core: renamed mutex * core: revert Reheap changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several race conditions in the txpool:
txList.SetBasefee(),txlist.Removed()andtxlist.Reheap()on who is allowed to reheap the listtxListon updating thetxlist.stalescountertxpool.loop()and reseting the txpool's blockchain between teststxpool.chain.gaslimitfrom within a test