New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/debug: remove deprecated flags #23368
internal/debug: remove deprecated flags #23368
Conversation
The removed flags are removed in the main portion of geth, this removes it internally too.
The code doesn't compile. |
This PR now also removes the legacy --debug and legacy --backtrace flag, since travis didn't like me leaving that in. |
it now passes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One year should be enough for those debug flags imo
can this please be merged then? |
@Zachinquarantine We're currently preparing a hotfix release, until this is done we can't merge any other PR's. Your PR will be included in 1.10.9 |
Good |
* internal/debug: remove deprecated flags The removed flags are removed in the main portion of geth, this removes it internally too. * internal/debug: remove legacy --debug and legacy --backtrace flag * Update flags.go Co-authored-by: Martin Holst Swende <martin@swende.se>
The deprecated flags are removed in the main portion of geth, this PR removes it internally too.