Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/debug: remove deprecated flags #23368

Merged
merged 3 commits into from Sep 7, 2021

Conversation

Zachinquarantine
Copy link
Contributor

@Zachinquarantine Zachinquarantine commented Aug 9, 2021

The deprecated flags are removed in the main portion of geth, this PR removes it internally too.

The removed flags are removed in the main portion of geth, this removes it internally too.
@karalabe
Copy link
Member

The code doesn't compile.

@Zachinquarantine
Copy link
Contributor Author

Zachinquarantine commented Aug 12, 2021

This PR now also removes the legacy --debug and legacy --backtrace flag, since travis didn't like me leaving that in.
Edit: I'm dumb, this PR already removed it when I created the PR, I just didn't remove it fully until now.

@Zachinquarantine
Copy link
Contributor Author

The code doesn't compile.

it now passes!

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One year should be enough for those debug flags imo

@Zachinquarantine
Copy link
Contributor Author

LGTM

can this please be merged then?

@MariusVanDerWijden
Copy link
Member

@Zachinquarantine We're currently preparing a hotfix release, until this is done we can't merge any other PR's. Your PR will be included in 1.10.9

@holiman holiman merged commit ca5bc67 into ethereum:master Sep 7, 2021
@holiman holiman added this to the 1.10.9 milestone Sep 7, 2021
@Zachinquarantine Zachinquarantine deleted the removeflagsininternal branch September 7, 2021 12:19
@arslan-raza-143
Copy link

Good

yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
* internal/debug: remove deprecated flags

The removed flags are removed in the main portion of geth, this removes it internally too.

* internal/debug: remove legacy --debug and legacy --backtrace flag

* Update flags.go

Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants